On Thu, 31 Oct 2024 16:18:17 GMT, Andy Goryachev <[email protected]> wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Scene: Remove missed doPrivileged use
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/Disposer.java line
> 62:
>
>> 60: tgn != null;
>> 61: tg = tgn, tgn = tg.getParent());
>> 62: Thread t = new Thread(tg, disposerInstance, "Prism Font
>> Disposer");
>
> very minor: I would have separated `for()` from L62 by a newline. This `for`
> is already confusing enough.
Done
> modules/javafx.graphics/src/main/java/com/sun/javafx/util/ModuleHelper.java
> line 39:
>
>> 37:
>> 38: static {
>> 39: verbose = Boolean.getBoolean("javafx.verbose");
>
> minor I would rather moved it to L36
Done
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1619#discussion_r1825613161
PR Review Comment: https://git.openjdk.org/jfx/pull/1619#discussion_r1825622675
