On Thu, 17 Apr 2025 21:06:08 GMT, Andy Goryachev <[email protected]> wrote:
>> I'll double check and will let you know tomorrow.
>>
>> A code search shows that these are only used in 5 classes: ButtonBar,
>> ButtonBarSkin, Dialog, DialogPane, Properties, so chances are it's a digital
>> fossil.
>
> I can confirm that we don't use these `//$NON-NLS-*` comments in javaFX.
>
> `<rant>`
> These comments were invented as a way to solve the localization problem. The
> problem is real, but the "solution" was exactly the opposite. Instead of
> marking the strings that don't need to be localized, what should have
> happened is to mark the string that need to be localized - with the
> information containing the context!
>
> example:
>
> // verb, as in "execute this test"
> String run = "Run";
>
>
> What I've done with some other projects was
>
>
> String run = TXT.get("Class.LocalizedResourceID.verb, as in execute this
> test", "Run");
>
>
> `</rant>`
Okay, I can remove them.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1779#discussion_r2050403015
