On Fri, 18 Apr 2025 09:22:27 GMT, John Hendrikx <[email protected]> wrote:
>> I can confirm that we don't use these `//$NON-NLS-*` comments in javaFX.
>>
>> `<rant>`
>> These comments were invented as a way to solve the localization problem.
>> The problem is real, but the "solution" was exactly the opposite. Instead
>> of marking the strings that don't need to be localized, what should have
>> happened is to mark the string that need to be localized - with the
>> information containing the context!
>>
>> example:
>>
>> // verb, as in "execute this test"
>> String run = "Run";
>>
>>
>> What I've done with some other projects was
>>
>>
>> String run = TXT.get("Class.LocalizedResourceID.verb, as in execute this
>> test", "Run");
>>
>>
>> `</rant>`
>
> Okay, I can remove them.
line 822 should be
`styleClasses.setAll("details-button");`
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1779#discussion_r2050722617
