On Fri, 27 Jun 2025 19:12:32 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> Johan Vos has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Process reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessRobot.java
>  line 161:
> 
>> 159:         int repeat = Math.abs(wheelAmt);
>> 160:         for (int i = 0; i < repeat; i++) {
>> 161:             view.notifyScroll((int) mouseX, (int) mouseY, wx, wy, 0, 
>> dff, 0, 0, 0, 0, 0, multiplierX, multiplierY);
> 
> are all parameters correct?  `modifiers` and `lines`, specifically?

It is a bit complex to easily determine if those parameters have relevance at 
all. There are no failing tests due to this, so I see this as a good 
opportunity to add tests in case issues (unexpected behavior) is detected.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1836#discussion_r2215241105

Reply via email to