On Mon, 7 Jul 2025 14:17:37 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process more reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessRobot.java > line 129: > >> 127: view.notifyMouse(MouseEvent.DOWN, getGlassEventButton(buttons), >> (int)mouseX-wx, (int)mouseY-wy, (int)mouseX, (int)mouseY, modifiers, true, >> true); >> 128: int buttonCode = getGlassEventButton(buttons); >> 129: view.notifyMouse(MouseEvent.DOWN, buttonCode, (int)mouseX-wx, >> (int)mouseY-wy, (int)mouseX, (int)mouseY, modifiers, true, true); > > This code (`view.notifyMouse(...`) is duplicated, and there are two > notifications of mouse down while there should be just one. > > The first line can be removed. Right, good catch! I removed that first line. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1836#discussion_r2190305053
