On Mon, 14 Jul 2025 22:17:56 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> Johan Vos has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Specify A as a double.
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessApplication.java
>  line 141:
> 
>> 139:             float scaleX = 1.f;
>> 140:             float scaleY = 1.f;
>> 141:             String scale = System.getProperty("glass.gtk.uiScale");
> 
> "gtk" ?

whoops. I took a similar approach here as the one used in GtkApplication, but 
it is not in line with my own suggestion to keep configuration out of this PR.
I removed this property check, as I believe configurations (via properties or 
not) should be discussed globally, and having one property already being used 
in the code, would make that discussion harder.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1836#discussion_r2215271585

Reply via email to