On Fri, 25 Jul 2025 19:49:21 GMT, Nir Lisker <[email protected]> wrote:
>> Ambarish Rapte has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - Merge branch 'master' into impl-metal >> - add comment for ES2SwapChain.getFboID >> - remove MTLLog >> - andy review comments 1 >> - changes for running apps in eclipse >> - review-update: jni method refactoring >> - add @Override >> - minor cleanup changes in glass >> - Use appropriate layer for setting opacity >> - Glass changes after Metal PR inputs >> - ... and 2 more: https://git.openjdk.org/jfx/compare/feb5d598...1a9a0a41 > > modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLSwapChain.java > line 166: > >> 164: >> 165: @Override >> 166: public void setOpaque(boolean opaque) { > > Should we warn somehow about this no-op? It could be confusing for the caller > for this to "fail" silently. Filed [JDK-8364672](https://bugs.openjdk.org/browse/JDK-8364672) for investigating this for all pipelines. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2253204519
