On Tue, 23 Sep 2025 11:11:24 GMT, Kevin Rushforth <[email protected]> wrote:
> Have you run it on Windows enough to know that it is stable there? If so, > then this seems fine, although I'm curious as to why you duplicated the > platform check logic rather than just calling the PlatformUtil methods. I was under the impression that after these tests were enabled in [JDK-8169285](https://bugs.openjdk.org/browse/JDK-8169285) we are running them on windows machine in our CI, which is wrong. So this test is not reliable run on windows machine at all. So its better if we just disable this test completely. Regarding not using PlatformUtil methods : If i import PlatformUtil class in these tests i get `package com.sun.javafx is declared in module javafx.base, which does not export it to the unnamed module`. I tried adding `--add-exports=javafx.base/com.sun.javafx.PlatformUtil=ALL-UNNAMED` in compiler args of swt job, that didn't work out. Also i was not sure whether we need to export this javafx.base class or not. So i went ahead and added utility code in test. Since we will be disabling this test completely, i will go ahead and remove all PlatformUtil related code. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1917#issuecomment-3323992727
