On Tue, 23 Sep 2025 07:50:08 GMT, Jayathirth D V <[email protected]> wrote:
> This test is failing intermittently on macOS and Linux platforms and it will > be fixed under [JDK-8367599](https://bugs.openjdk.org/browse/JDK-8367599). > > We need to skip this until > [JDK-8367599](https://bugs.openjdk.org/browse/JDK-8367599) is fixed. > > javafx.base/com.sun.javafx.PlatformUtil helps to determine individual > platforms on which test is running. But this module is exposed only to system > tests and not to SWT tests. So i am replicating this test utility code in > SWTCursorsTest. Have you run it on Windows enough to know that it is stable there? If so, then this seems fine, although I'm curious as to why you duplicated the platform check logic rather than just calling the PlatformUtil methods. modules/javafx.swt/src/test/java/test/javafx/embed/swt/SWTCursorsTest.java line 51: > 49: System.getProperty("javafx.platform"); > 50: private static final boolean ANDROID = > "android".equals(javafxPlatform) || > 51: "Dalvik".equals(System.getProperty("java.vm.name")); Is there a reason not to use `PlatformUtil` to do the OS checks? ------------- PR Review: https://git.openjdk.org/jfx/pull/1917#pullrequestreview-3257413363 PR Review Comment: https://git.openjdk.org/jfx/pull/1917#discussion_r2371936173
