On Wed, 17 Dec 2025 07:21:59 GMT, Ambarish Rapte <[email protected]> wrote:
>> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> create sampler states only once > > modules/javafx.graphics/src/main/native-prism-mtl/MetalMeshView.m line 244: > >> 242: atIndex:3]; >> 243: [phongEncoder setFragmentSamplerState:[material >> getSamplerState:SELFILLUMINATION] >> 244: atIndex:0]; > > 1. All `setFragmentSamplerState` are setting at index 0, should it not be > 0,1,2,3? > 2. Does this not require any changes to `PhongPS.metal`, The shader > functions in `PhongPS.metal` do not have a `sampler` parameter. > 3. Currently the `PhongPS.metal` file creates two samplers in shader file > itself and uses those for sampling. May be that should be modified to use > these samplers that are set using `setFragmentSamplerState` Thanks for the observations @arapte . Yes these changes are needed and it also has to be tested properly. So moving this PR back to draft stage. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2005#discussion_r2626143073
