On Tue, 30 Dec 2025 23:01:55 GMT, notzed <[email protected]> wrote:
>> As discussed on the mailing list.
>>
>> OpenGL requires an explicit glFinish() to synchronise with the video
>> refresh. The current usage is incorrect and against the specification.
>> This patch calls glFinish() after all windows have been drawn following a
>> pulse.
>
> notzed has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Merge part of #1929, call glXSwapIntervalEXT in preference to
> glXSwapIntervalSGI if available.
modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2SwapChain.java line
194:
> 192:
> 193: if (vsync)
> 194: context.getGLContext().finish();
In addition to a comment, you need to add curly braces. We do not allow a
single statement body for an "if" or "else" if it in another line.
Suggestion:
// ADD A COMMENT HERE
if (vsync) {
context.getGLContext().finish();
}
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1981#discussion_r2889849077
