On Tue, 30 Dec 2025 23:01:55 GMT, notzed <[email protected]> wrote: >> As discussed on the mailing list. >> >> OpenGL requires an explicit glFinish() to synchronise with the video >> refresh. The current usage is incorrect and against the specification. >> This patch calls glFinish() after all windows have been drawn following a >> pulse. > > notzed has updated the pull request incrementally with one additional commit > since the last revision: > > Merge part of #1929, call glXSwapIntervalEXT in preference to > glXSwapIntervalSGI if available.
No worries. It's been so long I wasn't sure it was even still active, but I'll have a look next week at where it's all at. Z On 5/3/26 23:31, Kevin Rushforth wrote: > > ***@***.**** commented on this pull request. > > ------------------------------------------------------------------------ > > In > modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2SwapChain.java > <https://github.com/openjdk/jfx/pull/1981#discussion_r2889849077>: > > > + if (vsync) > + context.getGLContext().finish(); > > In addition to a comment, you need to add curly braces. We do not > allow a single statement body for an "if" or "else" if it in another line. > > ⬇️ Suggested change > - if (vsync) > - context.getGLContext().finish(); > + // ADD A COMMENT HERE > + if (vsync) { > + context.getGLContext().finish(); > + } > > — > Reply to this email directly, view it on GitHub > <https://github.com/openjdk/jfx/pull/1981#pullrequestreview-3896313799>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AMIHG7IGS5LSAMS23ZN5WL34PF3DZAVCNFSM6AAAAACM6FYZMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQOJWGMYTGNZZHE>. > You are receiving this because you were mentioned.Message ID: > ***@***.***> > ------------- PR Comment: https://git.openjdk.org/jfx/pull/1981#issuecomment-4009085976
