On Fri, 20 Mar 2026 20:32:28 GMT, Alexander Zuev <[email protected]> wrote:
>> Changing validation procedure so only add http:// prefix for addresses that >> are not started from the supported preffixes (for now it's http and https >> but more can be added if needed). Also now the validation procedure is case >> insensetive so HTTPS:// also works fine. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > - renamed valid to hasSupportedPrefix; > - using already acquired address instead of requesting it again from the > text field; works as expected now (except we should be using https). will re-approve if you decide to change. apps/samples/Ensemble8/src/samples/java/ensemble/samples/controls/webview/WebViewApp.java line 72: > 70: final WebEngine webEngine = webView.getEngine(); > 71: final String DEFAULT_URL = "http://www.oracle.com/us/index.html";; > 72: final String[] allowedPrefixes = {"http://";, "https://"}; we probably should change to https:// in L71 and L93 noone should be using http:// anymore ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2112#pullrequestreview-3984207035 PR Review Comment: https://git.openjdk.org/jfx/pull/2112#discussion_r2968085288
