On Sun, 22 Mar 2026 15:07:15 GMT, Marius Hanl <[email protected]> wrote:
>> chuckyschluz has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add unit test
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewMouseInputTest.java
> line 417:
>
>> 415:
>> 416: // JDK-8202066: shift-click to contract a range should deselect
>> rows outside the new range
>> 417: @Test public void
>> test_jdk8202066_shiftClickContractsRangeDeselects() {
>
> I would recommend removing the JDK number from the test. It does not provide
> any value, especially since you already wrote a comment above.
> As simple as: `testShiftClickRangeDeselect` is sufficient.
>
> I also think you can remove the comment above this test. The JDK number does
> not really help as it is a not a bug but a performance improvement. The test
> is clear in itself IMO (which is good). Same below
Thank you for the feedback. I consolidated the two tests into a single
`testShiftClickRangeDeselect` and removed the comments above the tests.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2109#discussion_r2974663860
