On Mon, 23 Mar 2026 12:15:11 GMT, chuckyschluz <[email protected]> wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewMouseInputTest.java
>> line 417:
>>
>>> 415:
>>> 416: // JDK-8202066: shift-click to contract a range should deselect
>>> rows outside the new range
>>> 417: @Test public void
>>> test_jdk8202066_shiftClickContractsRangeDeselects() {
>>
>> I would recommend removing the JDK number from the test. It does not provide
>> any value, especially since you already wrote a comment above.
>> As simple as: `testShiftClickRangeDeselect` is sufficient.
>>
>> I also think you can remove the comment above this test. The JDK number does
>> not really help as it is a not a bug but a performance improvement. The test
>> is clear in itself IMO (which is good). Same below
>
> Thank you for the feedback. I consolidated the two tests into a single
> `testShiftClickRangeDeselect` and removed the comments above the tests.
Note that I think having both cases as seperate tests is fine for me. Tests
should always be small and self contained, so if you like, feel free to split
both cases.
Of course both tests should have a good test name. You can also provide more
information in `@DisplayName` if you like.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2109#discussion_r2974921595
