On Wed, 22 Apr 2026 12:45:14 GMT, Ziad El Midaoui <[email protected]> wrote:
>> Fixed popup size not changing to show more items or less when changing the >> number of items in `ComboBox` by adding a `popupResize` variable which >> triggers a request layout when there is change in items list. >> Tested with the test app in bug and MonkeyTester. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ziad El Midaoui has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains eight additional > commits since the last revision: > > - Merge branch 'openjdk:master' into 8325564.popupSize > - Merge branch 'openjdk:master' into 8325564.popupSize > - Fix scrollbar issue > - Merge branch 'openjdk:master' into 8325564.popupSize > - Removed 'popupResize' flag > - Merge branch 'openjdk:master' into 8325564.popupSize > - Merge branch 'openjdk:master' into 8325564.popupSize > - Fixed ComboBox popup size not changing after update. still see the scrollbar. So I think the problem identified in https://github.com/openjdk/jfx/pull/2052#issuecomment-3837743037 is still there. I've updated the test not only to add items but also remove them (making the list smaller, just in case) - see the latest version https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/bugs/ComboBox_PopupSize_8325564.java to reproduce, - click the combobox to show the popup, - click elsewhere to dismiss the popup - click update button - open the popup again Expecting to see no scrollbar, but: <img width="366" height="433" alt="Screenshot 2026-04-22 at 12 12 08" src="https://github.com/user-attachments/assets/7c831193-61b9-4935-8ace-e46a3842b317"; /> ------------- Changes requested by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2052#pullrequestreview-4157342272 PR Comment: https://git.openjdk.org/jfx/pull/2052#issuecomment-4299256338
