On Wed, 22 Apr 2026 12:45:14 GMT, Ziad El Midaoui <[email protected]> 
wrote:

>> Fixed popup size not changing to show more items or less when changing the 
>> number of items in `ComboBox` by adding a `popupResize` variable which 
>> triggers a request layout when there is change in items list.
>> Tested with the test app in bug and MonkeyTester.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Ziad El Midaoui has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains eight additional 
> commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 8325564.popupSize
>  - Merge branch 'openjdk:master' into 8325564.popupSize
>  - Fix scrollbar issue
>  - Merge branch 'openjdk:master' into 8325564.popupSize
>  - Removed 'popupResize' flag
>  - Merge branch 'openjdk:master' into 8325564.popupSize
>  - Merge branch 'openjdk:master' into 8325564.popupSize
>  - Fixed ComboBox popup size not changing after update.

In general I would say that if you have to rely on using Platform.runLater for 
some kind of layouting and size changes within a Control or Skin, the approach 
is usually not the right one. I would try to replace the runLater call with 
another implementation that fixes the issue as well somehow.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2052#issuecomment-4341999322

Reply via email to