On Fri, 15 May 2026 17:13:36 GMT, Andy Goryachev <[email protected]> wrote:
>> I think `pseudoClassStateChanged` is not necessary here. Maybe I will file a >> bug and create a simple PR for that, good point. > > Not sure I understand your response: the code that toggles > PSEUDO_CLASS_FOCUSED is likely to be necessary (it's a private constant, and > this is the only spot it's referenced from). > The `comment` does not seem to be needed. > > Or am I completely off the mark here? This is already one in the `focused` property, so not need manually at all: https://github.com/openjdk/jfx/blob/e091e1cbbc446026f6dce9b796bfc8de73fe219d/modules/javafx.graphics/src/main/java/javafx/scene/Node.java#L10230 https://github.com/openjdk/jfx/blob/e091e1cbbc446026f6dce9b796bfc8de73fe219d/modules/javafx.graphics/src/main/java/javafx/scene/Node.java#L8400-L8404 ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1935#discussion_r3249875205
