On Thu, 14 May 2026 18:44:23 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> javadoc
>
> modules/javafx.controls/src/main/java/javafx/scene/control/cell/CellUtils.java
> line 263:
>
>> 261: event.consume();
>> 262: });
>> 263: textField.setOnKeyPressed(t -> {
>
> this is interesting - could there be any compatibility issues after changing
> from `onKeyReleased` to `onKeyPressed`? what was the reason for this change?
>
> Also, this should probably be mentioned in the `Behavioral Changes` section.
Can mention it, yes. But I can't think of any change.
Before, this was never called. Because the bahvior of the cell handled it
first. Because we were listening only on key release here. Now, we are first,
and we can cancel the edit (as before) instead of any focus loss commit.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1935#discussion_r3249885774
