On Mon, 2 Mar 2026 22:14:15 GMT, Michael Strauß <[email protected]> wrote:
>> The current implementation of `Renderer.getPeerInstance()` looks up mappings >> by concatenating strings to form a combined key: >> >> peer = peerCache.get(name + "_" + unrollCount); >> >> >> This can be improved by not using strings to store the combined key, but >> using a simple `PeerCacheKey` class instead. >> The `Renderer` class then uses a single reusable `PeerCacheKey` object to >> look up mappings, making the lookup allocation-free. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > review comment Is this full agreement idea formalized somewhere? I was under the impression that if you get the needed amount of approvals, the PR can be merged unless the project lead blocks this. Getting full agreement on everything when more than the required number of reviewers are involved is in some cases not feasible imo. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2091#issuecomment-4489384993
