On Thu, 28 May 2026 14:55:34 GMT, Michael Strauß <[email protected]> wrote:

>> Several JavaFX controls use animations to convey state changes, some of 
>> which are controllable by developers (for example: `TitledPane.animated` or 
>> `Chart.animated`). However, none of those controls respect the 
>> `reducedMotion` preference that was introduced with 
>> [JDK-8341514](https://bugs.openjdk.org/browse/JDK-8341514).
>> 
>> This enhancement changes the behavior of the following control skins to take 
>> the `Scene.Preferences.reducedMotion` preference into account when 
>> determining whether to animate a state change:
>> 
>> * `TableRowSkinBase`
>> * `TitledPaneSkin`
>> * `TabPaneSkin`
>> * `PaginationSkin`
>> * Charts
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Michael Strauß has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   stale animation hardening

looks good, with a minor question (code is ok as is through)

Question: do we want to add a `lowPower` platform preference?  Did anyone 
encountered a need for it?

I can see at least two possible uses:
- disable animations (in the platform)
- save any outstanding buffers to persistent storage (in the application)

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2177#pullrequestreview-4430311527
PR Comment: https://git.openjdk.org/jfx/pull/2177#issuecomment-4624864346

Reply via email to