On Thu, 4 Jun 2026 19:54:53 GMT, Marius Hanl <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comment
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TitledPaneSkin.java
> line 197:
>
>> 195: /** {@inheritDoc} */
>> 196: @Override public void dispose() {
>> 197: cancelTransitionAnimation();
>
> Should we cancel animations in other skins as well? Or is there only a need
> here?
I've added some defensive code in the other controls as well to stop
potentially running animations in the `dispose()` method.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2177#discussion_r3358967360