On Thu, 4 Jun 2026 16:19:21 GMT, Ziad El Midaoui <[email protected]> wrote:
>> Fixed popup size not changing to show more items or less when changing the >> number of items in `ComboBox` by adding a `popupResize` variable which >> triggers a request layout when there is change in items list. >> Tested with the test app in bug and MonkeyTester. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ziad El Midaoui has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 10 additional > commits since the last revision: > > - Merge branch 'openjdk:master' into 8325564.popupSize > - Fixed Scrollbar issue with CSS > - Merge branch 'openjdk:master' into 8325564.popupSize > - Merge branch 'openjdk:master' into 8325564.popupSize > - Fix scrollbar issue > - Merge branch 'openjdk:master' into 8325564.popupSize > - Removed 'popupResize' flag > - Merge branch 'openjdk:master' into 8325564.popupSize > - Merge branch 'openjdk:master' into 8325564.popupSize > - Fixed ComboBox popup size not changing after update. The fix looks good overall. Tested with a few scenarios with a sample program. Could you please include a system headful test. suggestion for test steps: 1. Create a Stage with size such a ComboBox popup of 10 items does not exceed Stage. 2. Add a ComboBox with 10 items 3. Pick the color of stage background 4. Open ComboBox popup and pick color at item 5 (Do not move mouse) 5. Set only 2 items to ComboBox 6. Pick color again => Color in step 6 should be = stage background color and != color picked in step 4 ------------- PR Comment: https://git.openjdk.org/jfx/pull/2052#issuecomment-4914454757
