On Fri, 10 Jul 2026 12:35:14 GMT, Christopher Schnick <[email protected]> wrote:
>> Ziad El Midaoui has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 10 additional >> commits since the last revision: >> >> - Merge branch 'openjdk:master' into 8325564.popupSize >> - Fixed Scrollbar issue with CSS >> - Merge branch 'openjdk:master' into 8325564.popupSize >> - Merge branch 'openjdk:master' into 8325564.popupSize >> - Fix scrollbar issue >> - Merge branch 'openjdk:master' into 8325564.popupSize >> - Removed 'popupResize' flag >> - Merge branch 'openjdk:master' into 8325564.popupSize >> - Merge branch 'openjdk:master' into 8325564.popupSize >> - Fixed ComboBox popup size not changing after update. > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/ComboBoxPopupControl.java > line 476: > >> 474: final Region r = (Region) popupContent; >> 475: r.setMinSize(Region.USE_COMPUTED_SIZE, >> Region.USE_COMPUTED_SIZE); >> 476: r.setPrefSize(Region.USE_COMPUTED_SIZE, >> Region.USE_COMPUTED_SIZE); > > Setting those sizes looks to be the wrong approach. I can see that without > it, this PR does no longer work, but there should a more straightforward way > of getting the right height in sizePopup() than to change the sizes like > that. For example, why is the prefHeight not properly updating in this method > without those calls? I agree. Usually the code shouldn't mutate these variables at all. This can easily run into conflict with custom css. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2052#discussion_r3587630341
