On Thu, 9 Jul 2026 08:23:07 GMT, Marius Hanl <[email protected]> wrote:
>> modules/javafx.fxml/src/main/java/com/sun/javafx/fxml/builder/ProxyBuilder.java
>> line 211:
>>
>>> 209: }
>>> 210: if (Collection.class.isAssignableFrom(retType)) {
>>> 211: return new ArrayListWrapper<>();
>>
>> should it be called `CollectionWrapper` ?
>>
>> or, why have this type at all - the `Set` case returns a `LinkedHashSet`
>> instance, so perhaps this case should return `LinkedList` maybe?
>
> Maybe something we could check in a follow up?
> If I understand the author correctly, it is not 100% clear if this is needed
> or not
I replaced `ArrayListWrapper` with a plain `ArrayList` and everything still
works and is green.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3564237403
