On Tue, 14 Jul 2026 15:06:43 GMT, Andy Goryachev <[email protected]> wrote:
>> # Support for Embedded Images, Text Highlights, Wavy Underlines >> >> ## Summary >> >> This PR adds new attributes to support embedded images, text highlights, and >> wavy underlines. >> >> The `RichEditorDemoApp` gains new context menus and enables drag and drop to >> showcase the new functionality. >> >> <img width="768" height="703" alt="Screenshot 2026-06-18 at 12 40 28" >> src="https://github.com/user-attachments/assets/678bdbac-6582-46ee-bd41-ea938df930bb"; >> /> >> >> >> >> ## Problem >> >> Among the feedback received after publishing the RichTextArea incubating >> module, a number of users complained about the need to support embedded >> images. Other users complained about difficulty to get the text highlighted >> or wavy underlined, and having these decorations controlled via CSS. >> >> >> ## Solution >> >> Support for images was intentionally missing in the initial release; this PR >> adds the feature. >> >> Adding highlights and underlines is a bit more complicated, for several >> reasons. One reason is that the existing highlighting mechanism supports >> mixing of arbitrary number of translucent colors - something that is pretty >> much impossible to do with CSS alone. >> >> A useful compromise is to offer a limited number of standard attributes that >> can be controlled via CSS: 5 highlights and 3 wavy underlines. >> >> >> ## Specification >> >> >> ### StyleAttributeMap Attributes >> >> New attributes: >> - EMBEDDED_IMAGE >> - TEXT_HIGHLIGHT_1 ... TEXT_HIGHLIGHT_5 >> - UNDERLINE_WAVY_1 ... UNDERLINE_WAVY_3 >> >> ### CSS Styling >> >> The styling of highlights and wavy underlines is determined by the >> stylesheet and can be changed by the user. >> >> The style selectors are: >> >> `.rich-text-area .text-highlight-1` ... `.rich-text-area .text-highlight-5` >> `.rich-text-area .underline-wavy-1` ... `.rich-text-area .underline-wavy-3` >> >> >> ### New Public APIs >> >> `EmbeddedImage` >> `FileListFormatHandler` >> `StyleAttribute.inlineNode()` >> `StyleAttribute.isInlineNode()` >> `StyledSegment.ofInlineNode()` >> `CellContext.RunDecor` >> `CellContext.decorateRun()` >> `RichTextArea.dropTargetProperty` >> `RichTextArea.clearDropTarget()` >> `RichTextArea.getStyleAttributeMap()` >> >> >> ### File Format Changes >> >> The data transfer format (also used by the demo app to save the .rich files) >> version string is changed, making the old files unreadable (no backward >> compatibility will be provided during incubation period). >> >> >> ### Breaking API Changes >> >> `DataFormatHandler.createStyledInput()` >> `StyledTextMod... > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > review comments I left a couple more inline comments. One more thing I spotted: `RtfStyledOutput` doesn't handle embedded images. File a follow-up for this? I see a placeholder for PARAGRAPH attributes, would it be helpful to add a similar placeholder for inline images? modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/FileListFormatHandler.java line 53: > 51: * Constructor. > 52: */ > 53: public FileListFormatHandler() { This class is intended to be a singleton. Why does it have a public constructor? modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/FileListFormatHandler.java line 121: > 119: return StyledSegment.of(" ", a); > 120: } > 121: } catch (Throwable e) { This should probably be be `catch (Exception e)` instead (we generally don't catch `Error` in normal operation) ------------- PR Review: https://git.openjdk.org/jfx/pull/2196#pullrequestreview-4695924994 PR Review Comment: https://git.openjdk.org/jfx/pull/2196#discussion_r3580368121 PR Review Comment: https://git.openjdk.org/jfx/pull/2196#discussion_r3580377981
