On Tue, 14 Jul 2026 15:31:19 GMT, Kevin Rushforth <[email protected]> wrote:

>> Andy Goryachev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   review comments
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/FileListFormatHandler.java
>  line 121:
> 
>> 119:                             return StyledSegment.of(" ", a);
>> 120:                         }
>> 121:                     } catch (Throwable e) {
> 
> This should probably be be `catch (Exception e)` instead (we generally don't 
> catch `Error` in normal operation)

The intent was to catch _anything_ - there is little value in bubbling anything 
up at this point.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2196#discussion_r3580455726

Reply via email to