On Tue, 28 Jul 2026 19:37:32 GMT, Andy Goryachev <[email protected]> wrote:
>> Nir Lisker has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - Number >> - Date/Time >> - BigDecimal/Integer >> - Reintroduce conversion methods for primitives >> - Retrieve default locale on creation > > modules/javafx.base/src/main/java/javafx/util/StringConverter.java line 38: > >> 36: /// - Except for `DefaultStringConverter`, formatting `null` returns an >> empty string, otherwise the type's `toString` is >> 37: /// used if it is suitable; parsing `null` or an empty string returns >> `null`. >> 38: /// - Immutable (the same converter can be reused, except for >> `DateTimeStringConverter`s that can only be reused on the > > This limitation probably needs to be added to `DefaultStringConverter` class > javadoc. We can keep it here as well. I should consider moving the docs on formatting and parsing to the methods themselves rather than putting them on the class level, and then removing this comment. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r3673870133
