On Wed, 29 Jul 2026 11:37:46 GMT, Nir Lisker <[email protected]> wrote:
> Which link is lost? this is about @kevinrushforth 's comment https://github.com/openjdk/jfx/pull/1880/changes#r2641532126 (look in the diff view) >> modules/javafx.base/src/main/java/javafx/util/converter/DateTimeStringConverter.java >> line 44: >> >>> 42: /// Reads the default locale at the time of creation. If the >>> default locale is changed during the application's life, >>> 43: /// new converters will use the new default locale. >>> 44: private static final Locale defaultLocale() { >> >> should these methods (also in `BaseTemporalStringConverter`) be moved to a >> utility, maybe in in `com.sun.javafx` ? >> or as package-protected in `BaseStringConverter` > > If retrieval of the default locale is done with > `Locale.getDefault(Locale.Category.FORMAT)` in more places in the codebase, > it can be moved to a utility. This is a specific way to get the default > locale. It could be moved to `BaseStringConverter`, but that would imply a > standard amongst string converters (which is true, but there are only 2 use > cases). I don't mind either way. yes, only in 2 cases; so it's good either way. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1880#issuecomment-5119193384 PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r3675241612
