On Thu, 6 Aug 2026 22:25:19 GMT, Alexander Matveev <[email protected]> wrote:
> - Added documentation for "resource" protocol. > - "resource" protocol was added with JDK-8238755 to support GraalVM > native-image. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). modules/javafx.media/src/main/java/javafx/scene/media/Media.java line 339: > 337: * Constructs a <code>Media</code> instance. This is the only way to > 338: * specify the media source. The source must represent a valid > <code>URI</code> > 339: * and is immutable. Only HTTP, HTTPS, FILE, JAR, and RESOURCE > <code>URL</code>s are supported. If the just out of curiosity, could we use the actual codes ("https:", "jar:", ...) instead of HTTPS, JAR, ...? modules/javafx.media/src/main/java/javafx/scene/media/Media.java line 355: > 353: * <ul> > 354: * <li>The supplied URI must conform to RFC-2396 as required by > 355: * <a > href="https://docs.oracle.com/javase/8/docs/api/java/net/URI.html";>java.net.URI</a>.</li> why are we referencing java8 docs? shouldn't it be a relative ref? modules/javafx.media/src/main/java/javafx/scene/media/Media.java line 363: > 361: * for more information about URI formatting in general. > 362: * JAR URL syntax is specified in <a > href="https://docs.oracle.com/javase/8/docs/api/java/net/JarURLConnection.html";>java.net.JarURLConnection</a>. > 363: * RESOURCE URL syntax is specified in <a > href="https://www.graalvm.org/latest/reference-manual/native-image/dynamic-features/URLProtocols/";>URL > Protocols in Native Image</a>. similar question: why refer to graalvm.org? shouldn't we point to some authoritative document instead? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2251#discussion_r3732265657 PR Review Comment: https://git.openjdk.org/jfx/pull/2251#discussion_r3732247626 PR Review Comment: https://git.openjdk.org/jfx/pull/2251#discussion_r3732260621
