On Sat, 8 Aug 2026 03:11:50 GMT, Alexander Matveev <[email protected]> wrote:
>> - Added documentation for "resource" protocol. >> - "resource" protocol was added with JDK-8238755 to support GraalVM >> native-image. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8294872: Document "resource" protocol [v2] modules/javafx.media/src/main/java/javafx/scene/media/AudioClip.java line 74: > 72: * @param source URL string from which to load the audio clip. This > can be an > 73: * <code>http</code>, <code>https</code>, <code>file</code>, > <code>jar</code>, > 74: * <code>jrt</code>, and <code>resource</code> source. "resource source" is poorly phrased. suggestion: Supported schemes are .... modules/javafx.media/src/main/java/javafx/scene/media/package-info.java line 118: > 116: * > 117: * <table border="1"> > 118: * <caption>Supported Schemes / Protocols Table</caption> L119: the header says "Protocol" while the table lists schemes and protocols. I understand there is some mixing of related things - for example, the "P" in HTTP is for "protocol", but "http" (or "http:") is a URI scheme. So maybe revert adding "Schemes /" in L115,118 and just keep saying "protocol"? What do you think? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2251#discussion_r3753804698 PR Review Comment: https://git.openjdk.org/jfx/pull/2251#discussion_r3753851687
