On Wed, 5 Aug 2026 12:57:16 GMT, Jay Bhaskar <[email protected]> wrote:

> Issue: document.startViewTransition triggers texture update which is trying 
> to access GL based data which is not supported in JavaFX Webkit. 
> 
> Solution: After 623.1 upgrade, BitmapTexture and BitmapTextureJava are 
> unrelated class, since BitmapTextureJava::updateContent was no op code in 
> 622.1 upgrade, whose drawing method was commented out. JavaFX Webkit does not 
> have the OpenGL texture-upload and surface state hence making 
> BitmapTexture:updateContent method no op code for JavaFX Webkit platform 
> which restore 622.1 behavior. 
> 
> The TextureMapperTest.java test program covers JavaFX TextureMapper behavior, 
> the test pass with fix and failed without fix.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

I confirm that this fixes the problem. The included test crashes without the 
fix and passes with the fix. Even if the clipping code isn't 100% equivalent, 
it's still better to take this fix than to knowingly call code that will crash.

modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapper.cpp
 line 1519:

> 1517: #else
> 1518:     clipStack().push();
> 1519:     
> clipStack().intersect(enclosingIntRect(modelViewMatrix.mapRect(targetRect.rect())));

@arapte Can you verify that this is equivalent? Even if it isn't, we might 
decide to fix it in a follow-up, given that it is provably better to do this 
than crash with the above code.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/2245#pullrequestreview-4879418405
PR Review Comment: https://git.openjdk.org/jfx/pull/2245#discussion_r3733010953

Reply via email to