On Fri, 7 Aug 2026 02:25:34 GMT, Kevin Rushforth <[email protected]> wrote:

>> Issue: document.startViewTransition triggers texture update which is trying 
>> to access GL based data which is not supported in JavaFX Webkit. 
>> 
>> Solution: After 623.1 upgrade, BitmapTexture and BitmapTextureJava are 
>> unrelated class, since BitmapTextureJava::updateContent was no op code in 
>> 622.1 upgrade, whose drawing method was commented out. JavaFX Webkit does 
>> not have the OpenGL texture-upload and surface state hence making 
>> BitmapTexture:updateContent method no op code for JavaFX Webkit platform 
>> which restore 622.1 behavior. 
>> 
>> The TextureMapperTest.java test program covers JavaFX TextureMapper 
>> behavior, the test pass with fix and failed without fix.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapper.cpp
>  line 1519:
> 
>> 1517: #else
>> 1518:     clipStack().push();
>> 1519:     
>> clipStack().intersect(enclosingIntRect(modelViewMatrix.mapRect(targetRect.rect())));
> 
> @arapte Can you verify that this is equivalent? Even if it isn't, we might 
> decide to fix it in a follow-up, given that it is provably better to do this 
> than crash with the above code.

These seem different to me. The GL path can handle rounded corner rectangle 
clip / non-rectangular clip. I could not simulate the difference yet.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2245#discussion_r3748447623

Reply via email to