On Tue, 4 Aug 2026 15:56:24 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8388277-REDO]-Looked-up-color-fails-for--fx-background-color-in-JavaFX-CSS-file >> >> # Conflicts: >> # >> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java >> - 8388277: [REDO] Looked-up color fails for -fx-background-color in JavaFX >> CSS file > > modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line > 119: > >> 117: >> 118: if (node.styleHelper != null) { >> 119: setFirstStyleableAncestor(node.styleHelper, >> styleableAncestor); > > this changes the existing helper's ancestor unconditionally. the helper > might contain stale styles (especially during style or hierarchy updates from > within the listeners) not sure I follow: This just sets the ancestor, the same way we did before ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2225#discussion_r3741366078
