On Sat, 8 Aug 2026 18:51:44 GMT, Marius Hanl <[email protected]> wrote:
>> modules/javafx.graphics/src/main/java/javafx/stage/PopupWindow.java line 462:
>>
>>> 460: private void showImpl(final Window owner) {
>>> 461: Window rootWindow = getRootWindow(owner);
>>> 462: if (rootWindow == null) {
>>
>> not equivalent change: the old code set this.ownerWindow (to null in this
>> case, see L467)
>
> You have a point but I don't see how this could be a problem. I can't imagine
> a usecase where you want to call `show` just to reset the owner
I was pointing out that the change is not equivalent - in the old code, a
`null` owner causes `this.ownerWindow` be set to null, in the new code it does
not.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2236#discussion_r3750651689
