On Fri, 31 Jul 2026 21:09:39 GMT, Marius Hanl <[email protected]> wrote:

>> modules/javafx.graphics/src/main/java/javafx/stage/PopupWindow.java line 506:
>> 
>>> 504:         // JDK-8116444
>>> 505:         Window rootWindow = getRootWindow(owner);
>>> 506:         if (rootWindow == null) {
>> 
>> same thing - is it even possible for the `rootWindow` to be `null`?
>
> Yes, as you can see in the tests I wrote.

This is not a question about the tests you wrote.
Sorry, I need to spell my question out.  Looking at (old) L502:

`final Scene ownerScene = getRootWindow(owner).getScene();`

you see that `getScene()` dereferences the root window, so it can't be `null` 
there, I guess, otherwise we had seen an NPE.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2236#discussion_r3751300368

Reply via email to