On Thu, 6 Aug 2026 18:57:51 GMT, Alexander Zuev <[email protected]> wrote:
>> - To preserve functionality the separate native peers for tables and lists >> are created; >> - The list peer for now reports its role as a table for backward >> compatibility, that can be changed later; >> - Fixed the long existed bug where table reported incorrectly currently >> selected rows; >> - Added accessibilityFocusedUIElement to AccessibleBase; >> - Added functionality for array attribute count and array attribute values >> retrieval to AccessibleBase; >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Fixing the performance on the large tables and lists. In order to do so: > - Always return the NSArray of the appropriate size, otherwice VO reports > the table size incorrectly; > - To avoid querying of the entire content of the control fill in only > visible rows +/- additional 10 to avoid incorrect reporting due to the VO > caching when navigating with VO controls beyond the visible range; > - To request the visible range from the control's skin a new a11y attribute > added - VISIBLE_ITEM_RANGE. Since outside of the MacOS it is not used that > will not create any problems on other platforms; basically works identically to the master branch. two questions: 1. accessibility cursor sort of breaks after editing a cell in both ListView and TableView 2. question about updating visible range in case of mouse scrolling modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableViewSkinBase.java line 1076: > 1074: } > 1075: int firstIndex = firstVisibleCell.getIndex(); > 1076: return new int[] { firstIndex, > lastVisibleCell.getIndex() - firstIndex + 1 }; this code is not being hit when scrolling with the mouse. should the change in the viewport origin result in VISIBLE_ITEM_RANGE being updated? modules/javafx.graphics/src/main/java/javafx/scene/AccessibleAttribute.java line 814: > 812: * </ul> > 813: */ > 814: VISIBLE_ITEM_RANGE(int[].class), 1. this is a new attribute, so this PR needs as CSR, correct? 2. would it make more sense to use a more descriptive record instead of int[]? minor: the values in this enum are not sorted alphabetically - should they? do we care? ------------- PR Review: https://git.openjdk.org/jfx/pull/2217#pullrequestreview-4910027279 PR Review Comment: https://git.openjdk.org/jfx/pull/2217#discussion_r3761102101 PR Review Comment: https://git.openjdk.org/jfx/pull/2217#discussion_r3761222638
