On Tue, 11 Aug 2026 20:41:27 GMT, Alexander Zuev <[email protected]> wrote:
>> AccessibleAttribute is public API. The new attribute also needs `@since 28`. >> CSR is needed. >> >> (it's fine to keep it an `int[]`) > >> AccessibleAttribute is public API. The new attribute also needs `@since 28`. >> CSR is needed. > > Oh well. Time to learn how to create CSR for JavaFX. Yaaaaay.... [/sarcasm > off] > > 1. this is a new attribute, so this PR needs as CSR, correct? > > I have no idea. If that would be a change in the public API i would > definitely say yes, for the attribute - since we add it and not changing the > meaning of the existing attribute - may be? Gray area for me honestly. > @kevinrushforth Any comments? It's new API, so yes, a CSR is in order. > > minor: the values in this enum are not sorted alphabetically - should they? > > do we care? > > Not really. Changing the existing code just to sort the enum - i would hate > to do so, i prefer to keep the history cleaner, it's an old code, technical > binding of the parameters to the native bound variables, nobody really looks > at it except the compiler. Yeah, let's not do this. In addition to creating diff churn for no good reason, this would techincally be an incompatible change, since it would change the result of the "ordinal()" method. In practice I can't imagine that wouldn't matter, but ... > > AccessibleAttribute is public API. The new attribute also needs `@since > > 28`. CSR is needed. > > Oh well. Time to learn how to create CSR for JavaFX. Yaaaaay.... [/sarcasm > off] Same way as you would for the JDK. :) ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2217#discussion_r3762363549
