On Tue, 11 Aug 2026 18:23:21 GMT, Nir Lisker <[email protected]> wrote:
>> Adds a section for button events and clarifies the existing sections. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Added clarifications for the Movement section Nir, I am sorry. I think we need a fresh pair of eyes to give constructive criticism. I am afraid I prefer the old version - perhaps with some clarifications - but the new version does not bring happiness. It could be just me, so perhaps someone else could chime in. modules/javafx.graphics/src/main/java/javafx/scene/input/MouseEvent.java line 26: > 24: */ > 25: > 26: package javafx.scene.input; this comment applies to mouse_events.svg (I don't know how to annotate the image in github). sorry to say that, but it has many issues. 1. MOUSE_DRAGGED: remove side line (it's not a fork) 2. "exit hist. area?" - decision point, so it should have two outcomes (yes and no), 2 lines 3. DRAG_DETECTED: again, only one line down 4. rhombus with some kind of check, and 3 outgoing lines: DragAndDrop path, FullDrag path, and one that leads to MOUSE_DRAGGED. I'd think the rhombus should name the criteria and all three outcomes need proper labels. ------------- PR Review: https://git.openjdk.org/jfx/pull/2238#pullrequestreview-4911051682 PR Review Comment: https://git.openjdk.org/jfx/pull/2238#discussion_r3761980547
