On Tue, 4 Aug 2026 00:40:14 GMT, Nir Lisker <[email protected]> wrote:
>> Adds a section for button events and clarifies the existing sections. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Review clarifications modules/javafx.graphics/src/main/java/javafx/scene/input/MouseEvent.java line 141: > 139: /// distinguish between these two cases, the event target can be tested > on equality with the node. > 140: /// > 141: /// Since `MOUSE_ENTERED`/`MOUSE_EXITED` are subtypes of > `MOUSE_ENTERED_TARGET`/`MOUSE_EXITED_TARGET`, they are also the "subtype" thing is present in the original doc and is quite confusing: aren't those distinct types? maybe instead we should just rephrase the whole thing saying the *TARGET events are delivered to parents while the ENTERED/EXITED ones to the target node only? the original phrase "It's still one event just switching types" actually explains the whole thing better. modules/javafx.graphics/src/main/java/javafx/scene/input/MouseEvent.java line 149: > 147: /// 3. During the bubbling phase, its type is switched back to > `MOUSE_ENTERED_TARGET`. > 148: /// > 149: /// If the event is filtered or consumed, it affects both event types. how? what happens? this give very little information. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2238#discussion_r3714973302 PR Review Comment: https://git.openjdk.org/jfx/pull/2238#discussion_r3714922378
