On Tue, 1 Sep 2026 12:16:35 GMT, Nir Lisker <[email protected]> wrote:
>> build.gradle line 181:
>>
>>> 179:
>>> 180: def cliProps = gradle.startParameter.projectProperties
>>> 181: localProps.forEach((name, value) -> {
>>
>> I wonder if we could do that in the `settings.gradle` instead?
>> To be honest I don't know that the best practise is (or if there even is
>> 'best way'), just something I was wondering
>
>> I wonder if we could do that in the settings.gradle instead?
>
> Probably, but it has Oracle's `buildClosed` configuration there that I didn't
> want to conflict with. I try to go for minimal friction for the time being.
> This step is crucial for freeing the *de-facto* properties file for its
> intended use, which will allow to use the proper Java toolchain and enable
> parallel builds and caches. When things are wired up correctly and the
> entanglement reduces, we can have a look at this again.
> The solution there is probably for Oracle to unify whatever it is they are
> doing in there with the public hooks that are provided, like this one.
>
>> To be honest I don't know that the best practise is (or if there even is
>> 'best way'), just something I was wondering
>
> The best practice for what? Reading a user's properties file? Not that I know
> of. The Gradle team admits it's a gap, they're just not sure what to do about
> it. See https://github.com/gradle/gradle/issues/12283.
Makes sense. I will review later as well.
> This step is crucial for freeing the de-facto properties file for its
> intended use, which will allow to use the proper Java toolchain and enable
> parallel builds and caches
I totally agree on this. And this will in the end benefit all of us. And it is
similar to other projects, which usually have some kind of git-ignored gradle
property file for local customization (Usually thr `gradle.properties`, but I
also saw projects with a similar name like the one in this PR, and as you
pointed out there is no standard name yet. And renaming a file later on is
easy, e.g. when there finally is a convention).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2240#discussion_r3904183076
