On Tue, 1 Sep 2026 09:14:31 GMT, Nir Lisker <[email protected]> wrote:
>> Allows using a Gradle properties file at the project level by requiring the >> user-specific one to be present in the user's Gradle dir. A Gradle >> properties file is necessary for a proper Gradle build system's >> configuration. The user file takes precedence over the project one. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Remove dirty merge artifact Change looks good, local testing is fine. This change would not alter regular builds unless one creates gradle-local.properties. There is a reference to `gradle.properties` in file `modules/javafx.media/src/main/native/xcode_project/java_home.sh` Could you please check if it requires any attention ? Suggested two changes. gradle-local.properties.template line 2: > 1: # > 2: # Copyright (c) 2013, 2023, Oracle and/or its affiliates. All rights > reserved. minor: revert to 2026 gradle-local.properties.template line 31: > 29: # when building JavaFX. Any settings you configure in the > gradle-local.properties # > 30: # file will have precedence over any values specified in the build script > itself. # > 31: # Don't place Gradle properties (org.gradle.*) or system properties > (systemProp.*) # Gradle properties (org.gradle.*) or system properties (systemProp.*): Developers can mistakenly add such properties to this file and fail to read this note, and the struggle to root cause it. Would it be convenient to add a warning or fail the build in `loadLocalProperties` function, if such properties are added ? ------------- Changes requested by arapte (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2240#pullrequestreview-5087381820 PR Review Comment: https://git.openjdk.org/jfx/pull/2240#discussion_r3912228796 PR Review Comment: https://git.openjdk.org/jfx/pull/2240#discussion_r3912698172
