On Sun, 6 Sep 2026 15:40:39 GMT, Michael Strauß <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use actual painted pixels to compute dirty rects > > modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWDrawingContext.java > line 90: > >> 88: * Features include: >> 89: * <ul> >> 90: * <li>Stroke and fill management (line width, line caps, joins, miter >> limits, dashes).</li> > > I'd strongly prefer if you used 4 spaces of indentation like everywhere else > in the codebase, and that you didn't include the closing `</li>`. I think we > should consider adding the 4-spaces rule to our very limited style guide, as > I don't think that repeated discussions or a free-for-all "everyone invents > their own style" is useful. Sorry, adjusted, that doc was a bit of a mess. I totally agree indents should be 4 spaces, and that we can even make that part of the limited style guide. My main criteria is always readable, not strictly conformant to anyone's style-of-the-day. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r3945356544
