On Tue, 22 Sep 2026 21:34:21 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Optimized dirty rect handling (benefits more than just SWDraingContext)
>
> modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWDrawingContext.java
> line 1206:
>
>> 1204:
>> 1205: // Ensure it's a Prism image
>> 1206: if (!(platformImage instanceof com.sun.prism.Image
>> prismImage)) {
>
> `GraphicsContext::drawImage()` silently ignores a `null` image, should this
> method simply return instead of throwing an exception?
I think it's better to have this fail; this can't happen for users, it only
happens when using something like the stub toolkit (ie. during tests) and I
think showing that clearly instead of continuing silently is better then.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r4134116001
