On Tue, 8 Sep 2026 13:36:40 GMT, Marius Hanl <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix logic error, luckily 5000 tests caught it
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/ListenerList.java
> line 119:
>
>> 117: }
>> 118: finally {
>> 119: if (!wasLocked) {
>
> Is it possible to write a regression test for the logic error?
Many tests already fail if you get this wrong (it was a bad commit on my side),
it perhaps wasn't 5000 tests that failed, but it was a lot :)
I think there even already is a targetted test (but it is so fundamental that
many others will fail as well).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r3959410638
