On Fri, 11 Sep 2026 23:43:13 GMT, Kevin Rushforth <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix logic error, luckily 5000 tests caught it
>
> modules/javafx.base/src/main/java/javafx/beans/value/ChangeListener.java line
> 53:
>
>> 51: * that is, it is equal to {@code observable.getValue()} at the time
>> of invocation. The {@code oldValue}
>> 52: * is the value that was reported as {@code newValue} in the
>> previous notification delivered to the same
>> 53: * listener.
>
> This is only true for the classes that now use the listener manager
> implementation. Also, for the first notification, the `oldValue` was not
> reported as `newValue` in a previous notification because there was none.
Yes, since it is an interface, we can only describe the behavior we want but
can only guarantee that it is so for FX provided implementations (and even
there we haven't switched all of them). I can adjust the wording here.
For the 2nd part I can include wording like "...for any subsequent
notifications oldValue is the value that was reported as the newValue in the
previous notification..."
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r4001548583
