On Tue, 15 Sep 2026 19:05:33 GMT, Andy Goryachev <[email protected]> wrote:

>> Philemon Hilscher has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8222454: Review fixes
>>   
>>   Signed-off-by: Philemon Hilscher <[email protected]>
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/CellBehaviorBase.java
>  line 219:
> 
>> 217:         // If the mouse event is not contained within this TreeCell, 
>> then
>> 218:         // we don't want to react to it.
>> 219:         if (!cell.contains(x, y)) {
> 
> we need to keep `cell.isEmpty()` check here because the model size can change 
> before an existing empty cell is updated (similarly to the cell filter 
> reproducer I've provided earlier)

I'm confused. Clicking an empty cell is allowed, I can't see why it should not.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2129#discussion_r4019720307

Reply via email to