On Fri, 25 Sep 2026 11:42:53 GMT, Michael Strauß <[email protected]> wrote:
>> Strange code indeed, but preexisting. But I just realized, we could use >> `NodeHelper` here as well. >> >> The old code was even more weird by checking the `toString()` result, so it >> is a bit better now. > > While we don't usually do the "since we're here, we can change that as well", > in this case it seems like it's just a very simple oversight of the original > implementation, wouldn't you think? I can't see how, for example, adding a > completely unrelated style class should change this behavior here. Ah I misunderstood your first comment. I focused too much on making sure the semantics were exactly the same as before. You are right, will change. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2191#discussion_r4104223645
