On Wed, 23 Sep 2026 15:13:47 GMT, Michael Strauß <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> formatting and test changes
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TwoLevelFocusListBehavior.java
> line 195:
>
>> 193: Parent p = tlNode.getParent();
>> 194: if (p != null) {
>> 195: if (p.getStyleClass().size() == 1 &&
>> p.getStyleClass().contains(Properties.COMBO_BOX_STYLE_CLASS)) {
>
> This seems very strange. We detect a combo box here, but not if it has
> another (possibly unrelated) style class.
Strange code indeed, but preexisting. But I just realized, we could use
`NodeHelper` here as well.
The old code was even more weird by checking the `toString()` result, so it is
a bit better now.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2191#discussion_r4084787056
