This was found in 
[JDK-8365309](https://bugs.openjdk.org/browse/JDK-8365309)(https://github.com/openjdk/jfx/pull/2299)
 and is also closely related, as solving this issue here makes life easier to 
solve the refactoring in that PR in a clean way.

`TitledPaneSkin` is the only `Control` (Skin) that caches the `Node` via 
`setCache`, only for embedded devices.

I propose to remove it.
Because:
- Other `Control` (Skin)s do not have this special treatment
- Embedded check is not a real indicator how powerful a device is
- Currently, when the animation is cancelled the `setCache(false)` may never 
run, making the flag permanent
- Since [JDK-8385459](https://bugs.openjdk.org/browse/JDK-8385459), we will 
respect the `reducedMotion` user preference. This can be easily used to disable 
all animations, including the `TitledPane` one

---------
- [x] I confirm that I make this contribution in accordance with the [OpenJDK 
Interim AI Policy](https://openjdk.org/legal/ai).

-------------

Commit messages:
 - 8393545: TitledPaneSkin caches animation on embedded devices

Changes: https://git.openjdk.org/jfx/pull/2336/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=2336&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8393545
  Stats: 17 lines in 1 file changed: 0 ins; 17 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/2336.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/2336/head:pull/2336

PR: https://git.openjdk.org/jfx/pull/2336

Reply via email to